make _request_timeout args work as expected; add default timeout#7
Open
mike-eh2 wants to merge 1 commit intodcbark01:masterfrom
Open
make _request_timeout args work as expected; add default timeout#7mike-eh2 wants to merge 1 commit intodcbark01:masterfrom
mike-eh2 wants to merge 1 commit intodcbark01:masterfrom
Conversation
Author
|
@dcbark01 looks like this repo is unmaintained but I'm hoping you get a notification about this and consider approving it. Maintaining a public fork would be problematic for my team, but making our fork private would impose some technical challenges for our build pipeline, so getting this merged into the upstream would be ideal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My team was intermittently receiving alerts about the following error coming from requests through the PI web API client:
I saw that the client's API methods do accept
_request_timeoutarguments, but those arguments are not actually passed through to the request, so they don't do anything. This PR does two things:_request_timeoutarg so that it works as intendedWe have been running this branch in production and our timeout issues are resolved.